Skip to content

Make WorkingSetSorter extend ViewerComparator #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2024
Merged

Make WorkingSetSorter extend ViewerComparator #2613

merged 2 commits into from
Dec 10, 2024

Conversation

@akurtakov
Copy link
Member

@akurtakov akurtakov commented Dec 10, 2024

Modernize code a bit too.

@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Dec 10, 2024

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 9632a6b9dda1449d391e76dd36203563369fc9b4 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 10 Dec 2024 15:58:11 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
index 5e9f968e31..52eee57bc2 100644
--- a/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.navigator.resources/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.navigator.resources; singleton:=true
-Bundle-Version: 3.9.500.qualifier
+Bundle-Version: 3.9.600.qualifier
 Bundle-Activator: org.eclipse.ui.internal.navigator.resources.plugin.WorkbenchNavigatorPlugin
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

Test Results

  607 files   -  1 213    607 suites   - 1 213   42m 26s ⏱️ - 55m 15s
7 729 tests ±     0  7 450 ✅  -     51  279 💤 + 51  0 ❌ ±0 
8 116 runs   - 16 229  7 835 ✅  - 15 761  281 💤  - 468  0 ❌ ±0 

Results for commit 863287a. ± Comparison against base commit d3971fe.

This pull request skips 51 tests. 
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.TextHandlerTest ‑ testEditableText
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePartAndPerspective
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePartAndPerspectiveAndWindow
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePartAndWindow
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePartOnly
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePerspectiveAndWindow
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePerspectiveOnly
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInWindowOnly
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerSwitchToInactivePart
…

♻️ This comment has been updated with latest results.

@akurtakov akurtakov self-assigned this Dec 10, 2024
@akurtakov akurtakov merged commit 4721af7 into eclipse-platform:master Dec 10, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@akurtakov akurtakov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akurtakov @eclipse-platform-bot